chore: create-cli cleanup #792
Conversation
|
@umutuzgur , I opened #803 with some changes to be merged here, into this branch. I didn't commit into this branch because I would like to see how this branch is working in your local env. I tried a lot without success. The only way I found to make it work was removing all ESM references/packages. That's why I pushed all changes in a separated branch. |
* chore: remove all ESM packages/references [gh-0] * chore: add same fullname logic from fullname package [gh-0] * fix: revert package.json build script to prepare * chore: use commonjs deps versions [gh-0] * chore: adjust template urls tag version [gh-0] * chore: add create-cli E2E tests [gh-0] * chore: add create-cli E2E tests [gh-0] * chore: add create-cli E2E tests [gh-0] * fix: execa version [gh-0] * fix: execa version [gh-0]
|
@umutuzgur , I added a retrial mechanism when downloading the template from a specific version tag/branch. If the download fails (i.e. tag doesn't exists) the |
@nahuelon is this for testing? If not, we don't need this. We shouldn't have a fallback for cases that are basically our mistakes |
@umutuzgur , I removed the 'fallback to |
I hereby confirm that I followed the code guidelines found at engineering guidelines
Affected Components
Notes for the Reviewer
Changes are described in #803
preparescript renaming was reverted (TODO: investigate why tests fails usingbuildscript).This PR adds a retry/fallback when the template download fails using the version tag/branch. If template couldn't be found,
mainbranch is used to download the latest version. This is helpful when we change git tag format or versioning naming.IMPORTANT: after merging this PR and releasing the new
create-cli, the templates will be downloaded using the tag/branch without thevprefix. So, release's tags MUST be like4.0.15.New Dependency Submission